Skip to content

Rework Kafka image to build from source#659

Merged
sbernauer merged 7 commits intomainfrom
feat/build-kafka-from-source
May 8, 2024
Merged

Rework Kafka image to build from source#659
sbernauer merged 7 commits intomainfrom
feat/build-kafka-from-source

Conversation

@sbernauer
Copy link
Copy Markdown
Member

@sbernauer sbernauer commented May 8, 2024 •
edited
Loading

Description

Supersedes #608

  • Separate everything into builder & final image including log4shell scanner
  • Add kafka/bin and kcat to the PATH
  • Add KCAT license files

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Does your change affect an SBOM? Make sure to update all SBOMs
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

lfrancke
lfrancke requested changes May 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor stuff

Comment thread kafka/Dockerfile Outdated
Comment thread kafka/Dockerfile Outdated
sbernauer and others added 2 commits May 8, 2024 11:52
@sbernauer @lfrancke
Update kafka/Dockerfile
3aeea7f 
Co-authored-by: Lars Francke <lars.francke@stackable.tech>
@sbernauer
Always run microdnf update before installing stuff
e17a87f
@sbernauer sbernauer requested a review from lfrancke May 8, 2024 09:55
@sbernauer sbernauer added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit 46a56ea May 8, 2024
@sbernauer sbernauer deleted the feat/build-kafka-from-source branch May 8, 2024 10:08
@maltesander maltesander mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lfrancke lfrancke lfrancke approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sbernauer @lfrancke